added support for event filters

app/adapters/joule/adapter.rb

@@ -106,8 +106,8 @@ module Joule
     # === END ANNOTATIONS ===
 
     # === BEGIN EVENTS ===
-    def read_events(stream, max_events, start_time, end_time)
-      result = @backend.read_events(stream.joule_id, max_events, start_time, end_time)
+    def read_events(stream, max_events, start_time, end_time, filter)
+      result = @backend.read_events(stream.joule_id, max_events, start_time, end_time, filter)
       {id: stream.id, valid: true, count: result[:count], events: result[:events]}
     end
 

app/adapters/joule/backend.rb

@@ -215,10 +215,13 @@ module Joule
     end
 
     # === EVENT METHODS ===
-    def read_events(stream_id, start_time, end_time)
+    def read_events(stream_id, max_events, start_time, end_time, filter)
       query = {'id': stream_id}
       query['start'] = start_time unless start_time.nil?
       query['end'] = end_time unless end_time.nil?
+      query['limit'] = max_events
+      query['filter'] = filter.to_json unless filter.nil?
+
       options = {query: query}
       begin
         resp = self.class.get("#{@url}/event/data.json", options)
@@ -226,7 +229,14 @@ module Joule
       rescue
         raise "connection error"
       end
-      resp.parsed_response.map{|event| event.deep_symbolize_keys}
+      if resp.parsed_response.is_a?(Hash)
+        resp.parsed_response.deep_symbolize_keys!
+        resp
+      else # backwards compatibility
+        events = resp.parsed_response.map{|event| event.deep_symbolize_keys}
+        count = if events.nil? then 0 else events.length end
+        {count: count, events: events}
+      end
     end
     # === ANNOTATION METHODS ===
     def create_annotation(annotation)
@@ -260,29 +270,6 @@ module Joule
       resp.parsed_response
     end
 
-    # === EVENT METHODS ===
-    def read_events(stream_id, max_events, start_time, end_time)
-      query = {'id': stream_id}
-      query['start'] = start_time unless start_time.nil?
-      query['end'] = end_time unless end_time.nil?
-      query['limit'] = max_events
-      options = {query: query}
-      begin
-        resp = self.class.get("#{@url}/event/data.json", options)
-        raise "error reading events #{resp.body}" unless resp.success?
-      rescue
-        raise "connection error"
-      end
-      if resp.parsed_response.is_a?(Hash)
-        resp.parsed_response.deep_symbolize_keys!
-        resp
-      else # backwards compatibility
-        events = resp.parsed_response.map{|event| event.deep_symbolize_keys}
-        count = if events.nil? then 0 else events.length end
-        {count: count, events: events}
-      end
-    end
-
     def delete_annotation(annotation_id)
       query = {'id': annotation_id}
       options = {query: query}

app/controllers/events_controller.rb

@@ -15,10 +15,18 @@ class EventsController < ApplicationController
   end
 
   def data
-    req_streams = EventStream.find(JSON.parse(params[:streams]))
+    # streams parameters is a JSON array
+    # [{id, filter},{id, filter},...]
+    stream_param = JSON.parse(params[:streams])
+    req_streams = stream_param.map do |param|
+      { stream: EventStream.find(param["id"]),
+        filter: param["filter"],
+        tag: param["tag"]
+      }
+    end
     # make sure the user is allowed to view these elements
-    req_streams.each do |stream|
-      unless current_user.views_nilm?(stream.db.nilm)
+    req_streams.each do |req_stream|
+      unless current_user.views_nilm?(req_stream[:stream].db.nilm)
         head :unauthorized
         return
       end

app/services/event_stream/read_events.rb

@@ -10,7 +10,8 @@ class ReadEvents
 
   end
 
-  def run(event_streams, start_time, end_time)
+  def run(requested_streams, start_time, end_time)
+    # requested_streams is an array [{stream: EventStream, filter: array},...]
     @start_time = start_time
     @end_time = end_time
     if (not @start_time.nil?) and (not @end_time.nil?) and (@start_time > @end_time)
@@ -19,13 +20,21 @@ class ReadEvents
     end
     # pull data from streams
     @data = []
-    event_streams.each do |stream|
+    requested_streams.each do |requested_stream|
+      stream = requested_stream[:stream]
+      filter = requested_stream[:filter]
+      tag = requested_stream[:tag]
       adapter = NodeAdapterFactory.from_nilm(stream.db.nilm)
-      result = adapter.read_events(stream, stream.db.max_events_per_plot, @start_time, @end_time)
+      result = adapter.read_events(stream,
+                                   stream.db.max_events_per_plot,
+                                   @start_time, @end_time,
+                                   filter)
       if not result.nil?
+        result[:tag] = tag
         @data.append(result)
       else
-        @data.append({id: stream.id, valid: false, count: 0, events: nil})
+        @data.append({id: stream.id, valid: false, count: 0, events: nil,
+                      tag: tag})
         add_warning("unable to retrieve events for #{stream.path}")
       end
     end

app/views/events/data.json.jbuilder

@@ -4,6 +4,7 @@ json.data do
     json.valid event_stream[:valid]
     json.count event_stream[:count]
     json.events event_stream[:events]
+    json.tag event_stream[:tag]
     json.start_time @start_time
     json.end_time @end_time
   end

spec/adapters/joule/adapter_spec.rb

@@ -17,7 +17,7 @@ describe Joule::Adapter do
     nilm = FactoryBot.create(:nilm, name: "test")
     stream = FactoryBot.create(:event_stream, db: nilm.db, db_folder: nilm.db.root_folder,
                                name: 'test_stream')
-    result = adapter.read_events(stream, 200, 1611421200000000, 1611421230000000)
+    result = adapter.read_events(stream, 200, 1611421200000000, 1611421230000000, [])
     expect(result[:id]).to eq stream.id
     expect(result[:valid]).to be true
     expect(result[:events].length).to eq 4

spec/adapters/joule/backend_spec.rb

@@ -55,7 +55,7 @@ describe Joule::Backend do
         backend = Joule::Backend.new(url, key)
         start_time = 1611421210000000
         end_time = 1611421235000000
-        result = backend.read_events(2, 200, start_time, end_time)
+        result = backend.read_events(2, 200, start_time, end_time, [])
         # should have 3 events
         expect(result[:count]).to eq 3
         expect(result[:events].length).to eq 3

spec/cassettes/Joule_Backend/Events/read_events/loads_events.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://127.0.0.1:3030/event/data.json?end=1611421235000000&id=2&limit=200&start=1611421210000000
+    uri: https://127.0.0.1:3030/event/data.json?end=1611421235000000&filter=%5B%5D&id=2&limit=200&start=1611421210000000
     body:
       encoding: US-ASCII
       string: ''

spec/cassettes/ReadEvents/when_boundary_times_are_not_specified/updates_the_streams.yml

@@ -289,7 +289,7 @@ http_interactions:
   recorded_at: Mon, 08 Mar 2021 21:26:43 GMT
 - request:
     method: get
-    uri: https://localhost:3030/event/data.json?id=4&limit=200
+    uri: https://localhost:3030/event/data.json?filter=%5B%5D&id=4&limit=200
     body:
       encoding: US-ASCII
       string: ''
@@ -348,7 +348,7 @@ http_interactions:
   recorded_at: Mon, 08 Mar 2021 21:26:52 GMT
 - request:
     method: get
-    uri: https://localhost:3030/event/data.json?id=1&limit=200
+    uri: https://localhost:3030/event/data.json?filter=%5B%5D&id=1&limit=200
     body:
       encoding: US-ASCII
       string: ''

spec/services/events/read_events_spec.rb

@@ -22,7 +22,10 @@ RSpec.describe 'ReadEvents' do
     end
     it 'makes one request per stream' do
       service = ReadEvents.new
-      service.run([@event_stream1, @event_stream2],0,100)
+      service.run([{
+                       stream: @event_stream1, filter: []},
+                       stream: @event_stream2, filter:[]],
+                  0,100)
       expect(service.success?).to be true
       expect(service.data).to eq [@event_stream1_data, @event_stream2_data]
       expect(@mock_adapter.event_run_count).to eq 2
@@ -44,11 +47,12 @@ RSpec.describe 'ReadEvents' do
     end
     it 'fills in the data that is available' do
       service = ReadEvents.new
-      service.run([@event_stream1, @event_stream2],0,100)
+      service.run([{stream: @event_stream1, filter: []},
+                   stream: @event_stream2, filter:[]],0,100)
       expect(service.warnings.length).to eq 1
       expect(service.data).to eq [
                                      @event_stream1_data,
-                                     {id: @event_stream2.id, valid: false, events: nil, count: 0}
+                                     {id: @event_stream2.id, valid: false, tag: nil, events: nil, count: 0}
                                  ]
       expect(@mock_adapter.event_run_count).to eq 2
     end
@@ -71,7 +75,7 @@ RSpec.describe 'ReadEvents' do
       events1 = EventStream.find_by_path("/Homes/AB Transients")
       events2 = EventStream.find_by_path("/basic/aux/events0")
       service = ReadEvents.new
-      service.run([events1, events2], nil, nil)
+      service.run([{stream:events1, filter:[]}, {stream:events2, filter:[]}], nil, nil)
       #bounds taken from test joule on vagrant instance
       # AB Transients: [1564632656344436 - 1564637216855134]
       # events 0 - no events

spec/support/mock_adapter.rb

@@ -16,7 +16,7 @@ class MockAdapter
     end
     {data: data, decimation_factor: 1}
   end
-  def read_events(event_stream,max_events, start_time, end_time)
+  def read_events(event_stream,max_events, start_time, end_time, filter)
     data = @events.select{|d| d[:event_stream]==event_stream}.first[:data]
     @event_run_count += 1
     data